Skip to content

Improve docstring for timeout param in unit_of_work decorator. #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stefano-ottolenghi
Copy link
Contributor

Quoting from https://neo4j.com/docs/python-manual/current/session-api/#_transaction_timeout

Note: Using with Neo4j 4.1 and earlier it is possible for the driver to override any value set with dbms.transaction.timeout. In 4.2 and later, dbms.transaction.timeout also acts as a maximum which the driver cannot override. For example, with a server setting of dbms.transaction.timeout=10s the driver can specify a shorter timeout (e.g. 5 seconds) but not a value greater than 10 seconds. If a greater value is supplied the transaction will still timeout after 10 seconds.

so I added a note in the related docstring accordingly.

@robsdedude robsdedude merged commit 76a034c into neo4j:5.0 Oct 12, 2022
@stefano-ottolenghi stefano-ottolenghi deleted the docstring-unit_of_word-improve branch October 21, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants